From: Peter H. Froehlich <peter.hans.froehlich@gmail.com>
Date: Tue, 27 Sep 2016 20:58:29 +0000 (-0400)
Subject: Fix unsigned conversion bug.
X-Git-Url: https://git.devinivas.org/?a=commitdiff_plain;h=e916d668f7b184c41ee3d912ccda8cc7ca4aa765;p=cs3210-lab1.git

Fix unsigned conversion bug.

Since readi() returns -1 for errors, checking with < against an unsigned
value is inadvisable. Checking with != works as intended however.
---

diff --git a/exec.c b/exec.c
index 6be6af1..4d7d97c 100644
--- a/exec.c
+++ b/exec.c
@@ -28,7 +28,7 @@ exec(char *path, char **argv)
   pgdir = 0;
 
   // Check ELF header
-  if(readi(ip, (char*)&elf, 0, sizeof(elf)) < sizeof(elf))
+  if(readi(ip, (char*)&elf, 0, sizeof(elf)) != sizeof(elf))
     goto bad;
   if(elf.magic != ELF_MAGIC)
     goto bad;