]> Devi Nivas Git - cs3210-lab0.git/commitdiff
nit in console interrupts
authorkaashoek <kaashoek>
Thu, 7 Sep 2006 00:00:33 +0000 (00:00 +0000)
committerkaashoek <kaashoek>
Thu, 7 Sep 2006 00:00:33 +0000 (00:00 +0000)
Notes
console.c

diff --git a/Notes b/Notes
index 8b476685a25d8012a9ebe30bf1509a429ef834f8..74c8aea2c3643e159efc1743667f588618f3166f 100644 (file)
--- a/Notes
+++ b/Notes
@@ -103,9 +103,10 @@ test: deadlock d/.. vs ../d, two processes.
 test: dup() shared fd->off
 test: does echo foo > x truncate x?
 
-sh: support pipes?  leave it for the class?
+sh: ioredirection incorrect now we have pipes
+sh: chain of pipes won't work, also ugly that parent closes fdarray entries too
 sh: dynamic memory allocation?
-sh: should sh support ; () &  --- need malloc
+sh: should sh support ; () &
 sh: stop stdin on ctrl-d (for cat > y)
 
 really should have bdwrite() for file content
index 8deca8792ad443ac54548cbfbecd83b8114b98dc..418aa84c9bcccb697c3ef67b93cdfacbda7f28f7 100644 (file)
--- a/console.c
+++ b/console.c
@@ -178,7 +178,6 @@ console_write(int minor, char *buf, int n)
 }
 
 
-// This is i8042reg.h + kbdreg.h from NetBSD.
 #define KBSTATP         0x64    // kbd controller status port(I)
 #define KBS_DIB         0x01    // kbd data in buffer
 #define KBDATAP         0x60    // kbd data port(I)